Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Zipped downloads are broken #101

Closed
jamiesnape opened this issue Mar 27, 2015 · 0 comments
Closed

Zipped downloads are broken #101

jamiesnape opened this issue Mar 27, 2015 · 0 comments
Labels
Milestone

Comments

@jamiesnape
Copy link
Contributor

  • in core/controllers/DownloadController.php the autoload fails:
    all new ZipStream allocations should be new ZipStream\ZipStream
  • same file, rename all calls add_file_from_path to addFileFromPath as that's the name of the method in ZipStream. Similar for add_file into addFile
  • repeat in core/models/pdo/FolderModel.php as you're operating on a ZipStream object. Perhaps rename the zipStream function into zipStreamWrapper or something more suggestive to avoid looking too hard for a lowercase vs uppercase Z 😄
  • rinse and repeat in modules/remoteprocessing/controllers/AdminController.php and
    modules/keyfiles/controllers/DownloadController.php

@cfarcas

@jamiesnape jamiesnape added the bug label Mar 27, 2015
@jamiesnape jamiesnape added this to the Version 3.4.1 milestone Mar 27, 2015
@jamiesnape jamiesnape self-assigned this Mar 27, 2015
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

1 participant