Skip to content
This repository has been archived by the owner on Sep 10, 2021. It is now read-only.

Fail to upgrade PrivateModules with Midas 3.4.2 #258

Closed
felixveysseyre opened this issue Sep 2, 2016 · 3 comments
Closed

Fail to upgrade PrivateModules with Midas 3.4.2 #258

felixveysseyre opened this issue Sep 2, 2016 · 3 comments

Comments

@felixveysseyre
Copy link

Hello,

I was trying to install several PrivateModules inside an instance of Midas 3.4.2.

After adding them correctly to Midas through the Admin section, I tried to upgrade them to latest version. The admin section was telling me they were already updated which was false.

Looking at https://github.com/midasplatform/Midas/blob/3.4.2/core/controllers/components/UtilityComponent.php#L450, it seems that ini files are searched only in modules directory and not privateModules directory.

Hope it will help.

@cpatrick
Copy link
Contributor

cpatrick commented Sep 2, 2016

That is correct. behavior. We removed the privateModules code paths as they added to request latency and (more importantly) code complexity. The modules should function correctly from the modules directory.

@cpatrick cpatrick closed this as completed Sep 2, 2016
@felixveysseyre
Copy link
Author

Weird thing therefore, I was able to add modules from a privateModules directory I created my self

@cpatrick
Copy link
Contributor

cpatrick commented Sep 2, 2016

That is odd...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants