Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search functionality in the system logs UI #556

Open
jayantbh opened this issue Oct 1, 2024 · 8 comments · May be fixed by #613
Open

Search functionality in the system logs UI #556

jayantbh opened this issue Oct 1, 2024 · 8 comments · May be fixed by #613
Assignees
@Ryadav0654
Labels
dev experience enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server

Comments

@jayantbh
Copy link
Contributor

jayantbh commented Oct 1, 2024

Currently all the logs show up in a streaming format, but finding out something specific requires me to use the browser find-in-page functionality.

It would be nice to highlight specific logs and have the ability to jump to them right within the app.
@jayantbh jayantbh added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server dev experience hacktoberfest labels Oct 1, 2024
@Ryadav0654
Copy link

Hi @jayantbh ,

I would like to work on this issue. Could you please assign it to me?

Thank you!

@jayantbh
Copy link
Contributor Author

jayantbh commented Oct 2, 2024

It's done!

Would be a good idea to share your approach before you begin, to avoid rework.

@Ryadav0654
Copy link

It's done!

Would be a good idea to share your approach before you begin, to avoid rework.

  • A search input to filter logs.
  • Highlighting of logs that match the search term.
  • Buttons to navigate to the next and previous highlighted logs.

@jayantbh
Copy link
Contributor Author

jayantbh commented Oct 2, 2024

Cool. I think in a subsequent update it'll be great to have a way to copy one or more lines of logs.

@Ryadav0654
Copy link

HI @jayantbh ,
I can't find the system logs UI section. Can you tell me where to locate it?
Thanks!

@jayantbh
Copy link
Contributor Author

jayantbh commented Oct 5, 2024

#555 (comment)

@jayantbh
Copy link
Contributor Author

Hey @Ryadav0654 how's it going? :)

@Ryadav0654 Ryadav0654 mentioned this issue Oct 10, 2024
Closed
4 tasks
@Ryadav0654
Copy link

Hi @jayantbh ,

I've created a pull request(#587) that implements a sticky, responsive search bar with log navigation (Previous/Next) and highlighting of matching search terms. It includes mobile-friendly layout adjustments.

Please review and let me know your feedback!

Thanks!

@aadarsh-nagrath aadarsh-nagrath mentioned this issue Oct 13, 2024
Closed
@Ryadav0654 Ryadav0654 linked a pull request Oct 24, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ryadav0654 Ryadav0654

Labels
dev experience enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server
Projects
None yet
Milestone
No milestone
2 participants
@jayantbh @Ryadav0654