Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including jQuery AFTER rivets breaks rv-value binder #725

Open
dnasir opened this issue Feb 26, 2018 · 1 comment
Open

Including jQuery AFTER rivets breaks rv-value binder #725

dnasir opened this issue Feb 26, 2018 · 1 comment

Comments

@dnasir
Copy link

dnasir commented Feb 26, 2018

This is most likely due to rivets assigning the jQuery object to a local variable during its initialisation phase. This bug can be demonstrated here:

http://embed.plnkr.co/dlHcGbS9kq8uCjGjdYKR/

A simple fix would be to use window.jQuery instead of the local variable, as demonstrated here:

http://embed.plnkr.co/xDiwQh/

I am personally in favour of removing dependency on jQuery altogether, and letting the consumers override existing binders themselves.

@84pennies
Copy link

84pennies commented Aug 14, 2018

May have the same issue. Using npm to import rivets es6 style and it's complaining about jQuery being undefined in the rv-value binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants