Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of euphonic widgets and model #107

Open
3 tasks
mikibonacci opened this issue Dec 6, 2024 · 0 comments · May be fixed by #108
Open
3 tasks

refactoring of euphonic widgets and model #107

mikibonacci opened this issue Dec 6, 2024 · 0 comments · May be fixed by #108

Comments

@mikibonacci
Copy link
Owner

mikibonacci commented Dec 6, 2024

As suggested by @AndresOrtegaGuerrero , we should refactor the euphonic widgets (the three tabs) to be only one, which can be adapted for each case by means of an attribute which describe the scope of the widget. For now this behaviour is implemented in Raman and IR widgets, not in euphonic ones.

This can greatly simplify readability, avoid code duplication (partially solved by inheritance but not very clearly), and probably help in solving some issue which euphonic produces when rendering (some data processing hangs and blocks the app).

  • one model
  • one widget
  • update authors in the files
@mikibonacci mikibonacci linked a pull request Dec 8, 2024 that will close this issue
9 tasks
@mikibonacci mikibonacci self-assigned this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant