Refactoring Euphonic MVC. #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unification of plot and settings widgets, as well as polymorphism instead of inheritance and composition. This will help maintaining the code clear and readable. This is still a draft commit, let's say. I started doing the unification in the euphonicmodel.py and in the structurefactorwidget.py - but the files, imports and everything need to be fixed
Putting init in the model, to inject correct traits.
Missing several things: - energy units conversion - qplanes - downloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #107
Unification of plot and settings widgets, as well as polymorphism instead of inheritance and composition. This will help maintaining the code clear and readable.
This is still a draft PR. I started doing the unification in the euphonicmodel.py and in the structurefactorwidget.py - but the files, imports and everything need to be fixed
TODO: