Allow dynamic array indexing in a data address. #547
Conversation
exjam
force-pushed
the
dynamic_array_index
branch
from
f2b34d9
to
88c4662
Compare
exjam
force-pushed
the
dynamic_array_index
branch
from
88c4662
to
672ee78
Compare
|
Very cool, this has been something that's been requested several times by users. It would be a very nice addition. I wonder if it is possible to do this purely through our data expression language. It would be really cool if we could use arbitrary data expressions to index into the arrays. E.g. It would be nice with some unit tests for this, you can take a look at @Dakror I believe you started looking into this feature. Maybe you want to help review and assist on this one? |
|
Thats what i get for not posting my PR. I have a complete dynamic address expression parsing branch lying around on my project. I'll see how or if we can combine these two branches. |
|
I would appreciate if you could share your code, I do not see an immediately obvious way to expand this to full expression parsing given that I'd need to find some way to plumb an expression interface through to the Child() call |
|
The answer is that there is no obvious way to do that at all but instead you need to break open large parts of the interpreter. I've submitted my code in #550 for you to look at. This way we can decide what to keep now that there seems some more interest in this functionality. |
exjam
force-pushed
the
dynamic_array_index
branch
from
f94dfc0
to
672ee78
Compare
This change allows arrays to be dynamically indexed e.g.
data-checked="views[view_index].filter.chat"is now valid whereas previously in place ofview_indexyou could only use an integer literal.This seems to work though I am not sure if there are any complications that I do not know about given that I am quite new to RmlUI.
If you're happy with the approach I have taken here, I could add some unit tests to cover this use case.