Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query string encoding issue #118

Open
iongion opened this issue Dec 9, 2014 · 1 comment
Open

Query string encoding issue #118

iongion opened this issue Dec 9, 2014 · 1 comment
Labels
defect enhancement

Comments

@iongion
Copy link

iongion commented Dec 9, 2014

Shouldn't query string encoding be done something like this:

var urlKeyName = encodeURIComponent(key),
      urlKeyValue = encodeURIComponent(replacements[prop][key])
queryParts.push(urlKeyName + '=' + urlKeyValue);
@millermedeiros millermedeiros mentioned this issue Jul 31, 2015
Merged
@millermedeiros
Copy link
Owner

we did some changes to the way query strings are handled, maybe it solved your problem. will release v0.12.2 soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@millermedeiros @iongion