You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before starting the refactor, we'd probably need to figure out why these tests were done linearly. It might be that the setup for the tests is too computationally heavy.
We can start by dividing this into two parts:
API v2 tests
API v3 tests
Then we can divide each of these into foreign and owner parts.
This alone would make it much more readable and more easy to see which tests are missing and could be added to the suite.
Describe alternatives you've considered
/
Additional context
I could be wrong and there is a very good reason why tests are done in this way. In this case, figuring out if all endpoints are tested and writing down which ones are missing would be also good e.g. making table of endpoints for apiv2 and apiv3 with a check if the endpoint is tested and a cross if it is not.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
First off, this might be more of a task. From what I can tell, we have a test that goes through the whole wallet life cycle https://github.com/mimblewimble/grin-wallet/blob/master/tests/owner_v3_lifecycle.rs#L47 which is good, but it would be much easier to see which parts we have covered with tests if we broke this down a bit.
Describe the solution you'd like
Before starting the refactor, we'd probably need to figure out why these tests were done linearly. It might be that the setup for the tests is too computationally heavy.
We can start by dividing this into two parts:
Then we can divide each of these into foreign and owner parts.
This alone would make it much more readable and more easy to see which tests are missing and could be added to the suite.
Describe alternatives you've considered
/
Additional context
I could be wrong and there is a very good reason why tests are done in this way. In this case, figuring out if all endpoints are tested and writing down which ones are missing would be also good e.g. making table of endpoints for apiv2 and apiv3 with a check if the endpoint is tested and a cross if it is not.
The text was updated successfully, but these errors were encountered: