-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifact Registry Repository Cleanup Policy #26
Comments
Hi @miAndreev, yes we can add this. Would you like to contribute to the module and provide a PR? |
Hi, I will try to provide a PR this week. |
awesome thank you! |
Hi, I've stumbled upon an issue while I was adding the requested functionality. When I start the tests they fail that there is no such params. The issue is that the hashicorp provider installed during the tests is version 4.0.0. This version does not have the options for adding the repository cleanup policies. I've checked in your versions.tf file and it has the following constraints >= 4.0.0 <6.0.0. I am not sure how does this constraints work in terraform, but for me it is kinda strange that it is not installing latest version between 4.0.0. and 6.0.0. I've bumped the version, but still it fails, because the iam.tf depends on github.com/mineiros-io/terraform-google-artifact-registry-repository-iam.git?ref=v0.2.0 which also have the same version constraints and again installs the 4.0.0 hashicorp provider. |
We added a new release to this repository. It contains new policy attributes for the artifact registry resource. |
Hi, I've tried it, but it does not take into account that some of the blocks are optional depending on the action. |
Hi,
do you plan to support Artifact Registry Repository Cleanup Policy?
If I understand correctly it is possible to do it in this module.
I used the examples in the google provider documentation to check if it's possible.
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/artifact_registry_repository#example-usage---artifact-registry-repository-cleanup
Thank you
The text was updated successfully, but these errors were encountered: