Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-info/JPMS? #1473

Open
Mechite opened this issue Jul 21, 2023 · 3 comments
Open

module-info/JPMS? #1473

Mechite opened this issue Jul 21, 2023 · 3 comments

Comments

@Mechite
Copy link

Mechite commented Jul 21, 2023

[WARN] **********************************************************************************************************************************************************************************
************************
[WARN] * Required filename-based automodules detected: [minio-8.5.2.jar]. Please don't publish this project to a public artifact repository! *
[WARN] **********************************************************************************************************************************************************************************
************************

As you can see, this Java client is not a JPMS compatible library.

@balamurugana
Copy link
Member

Feel free to send a PR

@Mechite
Copy link
Author

Mechite commented Jul 21, 2023

See #1474.
EDIT - I'd like to reiterate that I don't have the resources to work on this issue further, and am not very familiar with this build (Gradle builds tend to take a while to sink in). I've done the basic changes to give an idea of what changes need to be made and where.

@Mechite
Copy link
Author

Mechite commented Jul 21, 2023

An alternative approach I can propose is to use the Automatic-Module-Name header in the MANIFEST.MF in order to simply provide a stable name for the module. This is a way of achieving Java 1.8 compatibility without having to compile the module-info separately like a lot of projects have started doing. Downside? Much weaker encapsulation.

https://github.com/aws/aws-sdk-java-v2/ already uses this header to support JPMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants