You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently the Boefje.schema field shadows out BaseModel.schema. This can cause trouble, because BaseModel.schema is a dict of the schema (and BaseModel.schema_json is the JSON string representation of that dict)
To Reproduce
Run the Boefje module and monitor the logs; you should see a warning triggered by Pydantic due to the naming conflict
Expected behavior
No warnings should be triggered, and the schema should work as expected (which it probably already did).
Additional context
We should look for an alternative name
Perhaps we can use another field name, but use 'schema' as an aliased name (even if it's just for backward compatibility)
We need to make sure/ investigate it doesn't have compatibility issues when we change it
The text was updated successfully, but these errors were encountered:
Describe the bug
Currently the
Boefje.schema
field shadows outBaseModel.schema
. This can cause trouble, becauseBaseModel.schema
is a dict of the schema (andBaseModel.schema_json
is the JSON string representation of that dict)To Reproduce
Run the Boefje module and monitor the logs; you should see a warning triggered by Pydantic due to the naming conflict
Expected behavior
No warnings should be triggered, and the schema should work as expected (which it probably already did).
Additional context
The text was updated successfully, but these errors were encountered: