Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing an environment to ExternalTool.subprocess #479

Open
gregersn opened this issue Jan 11, 2017 · 0 comments
Open

Passing an environment to ExternalTool.subprocess #479

gregersn opened this issue Jan 11, 2017 · 0 comments

Comments

@gregersn
Copy link

Is there a reason that the env-option is not set up to be passed on to Popen.subprocess?

I am quite new to using this library, and I like it very much. But I have now run across an issue where I need to set some environment variables for an external tool, to get it to work. And my first thought was to just throw the env=foo to subprocess in the external tool filter. But discovered that that wasn't an option.

Adding it to the ExternalTool-class wouldn't be a problem, but I wanted to see if there was any thought behind why it is like it is, and if that would be advised against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant