-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java 8 JSR 310 compatibility #47
Comments
Hi, I used Mirage-SQL for the first time recently, but I really like it. What do you think about Date and Time API (JSR 310)? Here's my sample codes. However, I think there are two ways to achieve this (like below).
Which is better do you think? If I can, I'd like to send PR about this matter. |
Looks good. What do you think? @aadrian |
@MasatoshiTada I think "way 1" is better. Unfortunately not all JDBC drivers support JSR310 yet: most notably and incredibly: the Oracle DB one :( - so I think that dialect specific handling would also might be needed. Currently we have no tests (integration) for each dialect :( . Something with https://github.com/flapdoodle-oss/de.flapdoodle.embed.process might be a good start. |
Thank you for your comments!
Does this mean " Date date = resultSet.getDate(columnName);
LocalDate localDate = date.toLocalDate(); MyBatis's |
Add Java 8 JSR 310 compatibility.
The text was updated successfully, but these errors were encountered: