You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently running a cohttp-eio server only allows a user to set the port number of the local address to listen on, I think it would be good to let the user pass a full Eio.Net.Sockaddr.stream into the function so users can:
Change the IP address for a TCP socket (e.g. Eio.Net.Ipaddr.V4.any)
Note that you can use connection_handler to make your own run function fairly easily. We might want to provide an Eio.Net.run_server function in Eio (like Lwt has Lwt_io.establish_server).
Some other problems we might want to fix with that:
The cohttp version forces ~reuse_port:true, which should really be optional.
It requires a domain manager even if you don't need multiple domains.
Note that you can use connection_handler to make your own run function fairly easily. We might want to provide an Eio.Net.run_server function in Eio (like Lwt has Lwt_io.establish_server).
Ah, thanks! Yes I think making that a bit more obvious would be helpful (although it might just be me...). Plus one for Eio.Net.run_server and then I think a doc comment with an example would be great too :))
Currently running a cohttp-eio server only allows a user to set the port number of the local address to listen on, I think it would be good to let the user pass a full
Eio.Net.Sockaddr.stream
into the function so users can:Eio.Net.Ipaddr.V4.any
)cc: @bikallem @talex5
The text was updated successfully, but these errors were encountered: