Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async exn: Cohttp_lwt__Connection.Retry while Cohttp_lwt_unix.Client.call (OCaml 5, cohttp --dev) #963

Open
smondet opened this issue Jan 13, 2023 · 2 comments
Open

Async exn: Cohttp_lwt__Connection.Retry while Cohttp_lwt_unix.Client.call (OCaml 5, cohttp --dev) #963

smondet opened this issue Jan 13, 2023 · 2 comments

Comments

@smondet
Copy link

smondet commented Jan 13, 2023 •
edited
Loading

With today's master branch.

I have some code using Cohttp_lwt_unix.Client.call which works with OCaml 4.14.* and the released Cohttp.

On OCaml 5 it fails Cohttp_lwt__Connection.Retry, on a regular GET. Exception appears async (Shows up in the Lwt.async_exception_hook, cannot be caught).
@Julow
Copy link

Julow commented Jun 5, 2023

I get this exception with Cohttp_lwt_unix.Client.get version 6.0.0~alpha1. I also observe the async behavior.

That it's defined in module Connection seems to indicate that it shouldn't leak through functions in module Client ?

@mseri mseri mentioned this issue Jul 19, 2023
Merged
@mseri
Copy link
Collaborator

mseri commented Sep 18, 2023

Is the new alpha release still failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smondet @Julow @mseri