Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "timeout" pull request #95

Open
guruz opened this issue Feb 4, 2015 · 0 comments
Open

Merge "timeout" pull request #95

guruz opened this issue Feb 4, 2015 · 0 comments

Comments

@guruz
Copy link

guruz commented Feb 4, 2015

Hi,
We had experienced hanging sockets to the Amazon servers when using the Product Advertising API. This led to our application being deadlocked as soon as 5 sockets were hanging (5 is the default number of sockets for node's https agent).

When using lsof you could see it like this:

node      20371       user   11u     IPv4         abc        0t0        TCP xxxx:49297->72.21.215.235:https (ESTABLISHED)
node      20371       user   12u     IPv4         cde        0t0        TCP xxxx:45374->72.21.215.235:https (ESTABLISHED)
...

Using a fork with the casualsteps#1 pull request and setting the timeout to 10 seconds fixed the issue for us.

Would be nice to see this in the main codebase.

CC @kenleytomlin @ogoffart @jturcotte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant