Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can not disable notifications for ended polls #8890

Closed
Johann150 opened this issue Jun 25, 2022 · 2 comments
Closed

can not disable notifications for ended polls #8890

Johann150 opened this issue Jun 25, 2022 · 2 comments
Assignees
@syuilo
Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR

Comments

@Johann150
Copy link
Contributor

Johann150 commented Jun 25, 2022 •
edited
Loading

💡 Summary

There are notifications for ended polls, but unlike other notifications it is not possible to disable them.

🥰 Expected Behavior

Notification settings dialog has option to disable poll ended notification.

🤬 Actual Behavior

image

📝 Steps to Reproduce

  1. Go to: ⚙️ Settings > Basic settings > 🔔 Notifications > ⚙️ Notification settings
  2. Option "Polls ending" is missing, even though the string exists in the locales.

    misskey/locales/ja-JP.yml

    Line 1696 in c67c0df

    pollEnded: "アンケートが終了"

📌 Environment

Misskey version: d5ef683
@Johann150 Johann150 added the ⚠️bug? This might be a bug label Jun 25, 2022
@Johann150
Copy link
Contributor Author

Fix see misskey-dev/misskey.js#45

@Johann150 Johann150 added 🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR and removed ⚠️bug? This might be a bug labels Jun 25, 2022
@zyoshoka
Copy link
Contributor

Seems to have been fixed in #12434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syuilo syuilo

Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syuilo @Johann150 @zyoshoka