Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the code which we added that calls getOptions() to regenerate the options cache #8

Open
mark-friedman opened this issue Oct 5, 2021 · 0 comments
Open

Remove the code which we added that calls getOptions() to regenerate the options cache #8

mark-friedman opened this issue Oct 5, 2021 · 0 comments
Labels
enhancement New feature or request lexical variables Use this tag for the lexical variable plugin

Comments

@mark-friedman
Copy link
Collaborator

We might want to remove the code which we added that calls getOptions() to regenerate the options cache and instead change the doClassValidation_ method to not check the options at all. I was initially worried about the ramifications, but I’m increasingly convinced that it should be safe.

This might be the same thing as #6
@mark-friedman mark-friedman added enhancement New feature or request lexical variables Use this tag for the lexical variable plugin labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lexical variables Use this tag for the lexical variable plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mark-friedman