-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update petgraph and use StableGraph #12
Comments
@Bobhostern Something along these lines sounds great 👍 I think I'd prefer if we maintained both options somehow: the current slightly more performant option as well as a version based on I've been thinking about this for a while and I'm still unsure what the best abstraction for this is. Personally I think I'd like to see petgraph's I'm slightly tempted to just switch the |
I gave that a big attempt before picking the current way. There's a lot more traits that G & SG have in common now, though, than before. |
Any progress on updating petgraph dependency? Recent std changes made petgraph broken, which was fixed in 0.4.5. |
#16 doesn't address the changing indices, it just allows |
daggy 0.5.0 was just published which now depends on petgraph 0.4.5, fixing the issue on nightly. I'm going to leave this issue open though as I still think it would still be nice to add a |
I just opened a pull request with an early implementation of the StableDag structure in #21. |
Closed via #21. |
Hello.
I'm here, getting ready to use daggy in a project of mine, when I check Dag's documentation, and find out that removals may change indices. I looked around (docs.rs), and found that because daggy used petgraph 0.2.2, it missed out on petgraph 0.4.3's StableGraph.
I would like to propose updating, and building Dag off of StableGraph, in order to stablize indices.
The text was updated successfully, but these errors were encountered: