Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighthouse complaints #134

Open
mithi opened this issue Jul 26, 2020 · 7 comments
Open

Fix lighthouse complaints #134

mithi opened this issue Jul 26, 2020 · 7 comments
Labels
best practice Best practice in software development first-timers-only For people who want to contribute good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mithi
Copy link
Owner

mithi commented Jul 26, 2020

Open dev tools and generate report with lighthouse

  • Use video instead of gif
  • Use passive scroll listeners

Screen Shot 2020-07-26 at 10 39 06 PM

Screen Shot 2020-07-26 at 10 39 36 PM
@mithi mithi added best practice Best practice in software development first-timers-only For people who want to contribute good first issue Good for newcomers help wanted Extra attention is needed labels Jul 26, 2020
@mithi mithi changed the title Fix lighthouse compaints Fix lighthouse complaints Jul 26, 2020
@mithi
Copy link
Owner Author

mithi commented Jul 30, 2020

Screen Shot 2020-07-30 at 11 54 29 PM

@mithi mithi pinned this issue Aug 5, 2020
@mithi
Copy link
Owner Author

mithi commented Aug 13, 2020 via email

@vparine
Copy link

vparine commented Oct 1, 2020

@mithi Can I work on this?

@mithi
Copy link
Owner Author

mithi commented Oct 1, 2020

@mithi Can I work on this?

Sure! Thank you for your interest!
Don't forget to read the contributing guidelines and the recommended commit style guide! Thank you!

And let me know if you have any questions!

@mithi mithi closed this as completed Oct 2, 2021
@mithi mithi reopened this Oct 2, 2021
@disawalva
Copy link

Hi @mithi, can I pick this up?

@mithi
Copy link
Owner Author

mithi commented Nov 1, 2021

Hi @mithi, can I pick this up?

Hi @disawalva ,
Sorry for the late reply! Sure :) Please let me know if you have any questions. Thanks!

@disawalva
Copy link

Sure :)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Best practice in software development first-timers-only For people who want to contribute good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mithi @vparine @disawalva