From 0c8f70a03f91317641fe8cf7028064e8b80c32f3 Mon Sep 17 00:00:00 2001 From: Charissa Miller <48832936+clemiller@users.noreply.github.com> Date: Thu, 29 Feb 2024 09:26:25 -0500 Subject: [PATCH] 622 select by data source (#623) * bug fix * update changelog * bump version * add release date --- CHANGELOG.md | 5 +++++ nav-app/package-lock.json | 4 ++-- nav-app/package.json | 2 +- nav-app/src/app/classes/stix/data-component.ts | 4 ++-- 4 files changed, 10 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bab31131d..58ffea9c6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,11 @@ The creation of the tag can be disabled with the --no-git-tag-version if desired. --> +# 4.9.4 - 29 February 2024 + +## Fixes +- Fixed a bug with selecting techniques by data sources in the search & multi-select interface. See issue [#622](https://github.com/mitre-attack/attack-navigator/issues/622). + # 4.9.3 - 27 February 2024 ## Fixes diff --git a/nav-app/package-lock.json b/nav-app/package-lock.json index 56d5c669d..498a6adb6 100644 --- a/nav-app/package-lock.json +++ b/nav-app/package-lock.json @@ -1,12 +1,12 @@ { "name": "attack-navigator", - "version": "4.9.3", + "version": "4.9.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "attack-navigator", - "version": "4.9.3", + "version": "4.9.4", "license": "Apache-2.0", "dependencies": { "@angular/animations": "^14.3.0", diff --git a/nav-app/package.json b/nav-app/package.json index ebdc7129f..45e4f376a 100644 --- a/nav-app/package.json +++ b/nav-app/package.json @@ -5,7 +5,7 @@ "type": "git", "url": "https://github.com/mitre-attack/attack-navigator.git" }, - "version": "4.9.3", + "version": "4.9.4", "license": "Apache-2.0", "scripts": { "ng": "ng", diff --git a/nav-app/src/app/classes/stix/data-component.ts b/nav-app/src/app/classes/stix/data-component.ts index da9bdcf37..efdb2fd16 100644 --- a/nav-app/src/app/classes/stix/data-component.ts +++ b/nav-app/src/app/classes/stix/data-component.ts @@ -13,7 +13,7 @@ export class DataComponent extends StixObject { /** * Get techniques related to the data component * @param domainVersionID the ID of the domain and version - * @returns {string[]} technique IDs used by the data component + * @returns {Technique[]} list of techniques used by the data component */ public techniques(domainVersionID): string[] { const techniques = []; @@ -23,7 +23,7 @@ export class DataComponent extends StixObject { if (relationships.has(this.id)) { relationships.get(this.id).forEach((targetID) => { const technique = domain.techniques.find((t) => t.id === targetID); - if (technique) techniques.push(technique.id); + if (technique) techniques.push(technique); }); } return techniques;