Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with V-73509 #28

Closed
burnsjared0415 opened this issue Mar 23, 2020 · 2 comments · Fixed by #57
Closed

Issue with V-73509 #28

burnsjared0415 opened this issue Mar 23, 2020 · 2 comments · Fixed by #57
Assignees

Comments

@burnsjared0415
Copy link

Issues is that the registry for windows and inspec registry_key don't align on slashes, need to update the code to have:
variables to be added for gsub to work
keyvalue_netlogon = '\\\NETLOGON'
keyvalue_sysvol = '\\
\SYSVOL'

in both describe statements
it { should have_property keyvalue_sysvol.gsub('\', '\\\\') }
its (keyvalue_sysvol.gsub('\', '\\\\')) { should cmp 'RequireMutualAuthentication=1, RequireIntegrity=1'}

@karikarshivani karikarshivani self-assigned this Aug 16, 2021
@karikarshivani
Copy link
Contributor

From my tests, it looks like the existing code is correct. I did clean it up a little, and here are the results for both approaches (2019 and 2016):

DC_V-73509_2019_Pass.json.txt
DC_V-73509_Pass.json.txt

Screen Shot 2021-08-16 at 11 54 24 AM

@burnsjared0415 please let me know if this looks good to you.

@karikarshivani
Copy link
Contributor

Update: Both the previous and the new approaches worked when the control was executed from a Windows runner.

Screen Shot 2021-08-23 at 2 25 43 PM

Since the new approach worked from both the runners, a new issue for Windows 2019 has been created to use the new approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants