Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The urlparse module is renamed to urllib.parse in Python 3 #85

Closed
baljeet opened this issue Jun 15, 2017 · 9 comments
Closed

The urlparse module is renamed to urllib.parse in Python 3 #85

baljeet opened this issue Jun 15, 2017 · 9 comments

Comments

@baljeet
Copy link

baljeet commented Jun 15, 2017

from urlparse import urljoin

ImportError: No module named 'urlparse'

Line 13, flask_oauth.py

Should add try catch for python3 and python 2 compatibility

@baljeet
Copy link
Author

baljeet commented Jun 23, 2017

@mitsuhiko this can be closed!

@wooohoooo
Copy link

This Error is still present, right? Any way to solve it?

@edison12a
Copy link

Hey, I'm experiencing this same error on PythonAnywhere! Any solution please?

@PierrePaul
Copy link

I guess this can be re-opened?

@jayrbolton
Copy link

Also having this issue with python 3

@domdinicola
Copy link

updates on this?

@not-inept
Copy link

@domdinicola / @jayrbolton / others. I have a workaround solution for myself if you're set on using this library, though it's definitely a hack:

import urllib.parse as urlparse
import sys
sys.modules["urlparse"] = urlparse
sys.modules["urllib"] = urlparse
from flask_oauth import OAuth

This problem seems to originate from python3 shuffling things around. I'm currently looking at other libraries like authlib as an oauth replacement, but this one has always been nice, so I've also filed #96, this shouldn't be too hard to fix at anyrate.

@not-inept
Copy link

I missed it a few minutes ago, but it looked like this library was marked unmaintained a few months ago:

Unmaintained
Flask-OAuth is currently unmaintained. If you want to add OAuth support to your Flask website, we recommend using Flask-Dance instead, which is actively maintained.

@domdinicola
Copy link

@not-inept Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants