Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design-Tokens :: couldn't find a complete list of available CSS variables. Some parts mention changing colors with style={{ color: 'var(--primary--color--900)' but it would be great to have a full list of tokens. #871

Closed
Tracked by #863
mfal opened this issue Oct 21, 2024 · 4 comments

Comments

@mfal
Copy link
Member

mfal commented Oct 21, 2024

No description provided.

@mfal
Copy link
Member Author

mfal commented Oct 22, 2024

@gskyarts usually you should not get in touch with any CSS variables during development. Either use the React components or alternatively (if you are not using React) the class names (e.g. flow--button)

@mfal mfal closed this as completed Oct 22, 2024
@gskyarts
Copy link

I am a bit confused. Your documentation actually shows exactly what I'm referring to. Under Icons "Farben" section (https://mittwald.github.io/flow/03-components/content/icon), there's a code example that uses these CSS variables.

@maaaathis maaaathis reopened this Oct 22, 2024
@Jan-Eimertenbrink
Copy link
Member

I suspect that the section of the documentation is somewhat confusing. In general, an icon is always used in combination with other components and automatically adopts their colors. For example, an icon used with a heading automatically takes on the heading’s color. Therefore, manually overriding the color of an icon is usually unnecessary.

Since I understand that this can cause confusion, we will remove this section from our documentation and consider it when writing the guidelines for icons. Additionally, a section on the use of colors, as mentioned here, is planned.

@mfal
Copy link
Member Author

mfal commented Nov 14, 2024

Since we have updated the Icons page and introduced a new section about colors in general (including a list of color design tokens), this issue is completed for now.

@mfal mfal closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants