Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide Header Design Optimization #905

Closed
Nickzlos opened this issue Oct 24, 2024 · 2 comments · Fixed by #945
Closed

Styleguide Header Design Optimization #905

Nickzlos opened this issue Oct 24, 2024 · 2 comments · Fixed by #945
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Nickzlos
Copy link
Member

Nickzlos commented Oct 24, 2024

Description

There are a few minor discrepancies between the current styleguide header and the design that need to be corrected.
Below are the specific issues that should be addressed:

  • Wave Integration or Color Update:

Please integrate the "Wave" element from the design, or at least change the color of the header background to hosting-blue-200.

  • Margin adjustment

Ensure there is a 24px margin between header and content area.

  • Logo and Text Margin:

The margin between the Mittwald logo and the adjacent text should be 16px.

  • Logo and "flow"-text alignment:

Currently the "Flow"-Lettering doesn't align perfectly to the mittwald logo. It should align evenly at the bottom as shown in this picture:

Image

  • Remove h1-Tag

The "Flow" should not have a h1-Tag. It's part of the logo and not a part of the information architecture.

Refer to the creator of this issue for question and/or further instructions.
Thank you for your help!

@Nickzlos Nickzlos added documentation Improvements or additions to documentation good first issue Good for newcomers labels Oct 24, 2024
@Nickzlos Nickzlos changed the title Stylguide Header Design Optimization Styleguide Header Design Optimization Oct 25, 2024
@palidii
Copy link

palidii commented Oct 28, 2024

@Nickzlos I would like to try it, can you assign it to me? is it about the logo of the website?

@Nickzlos
Copy link
Member Author

Nickzlos commented Nov 4, 2024

Hey @palidii ,

Thanks for reaching out and your interest in helping. We appreciate the enthusiasm and the offer to contribute :)

Right now, we're still in the early stages of building the foundation. There's still a lot of internal communication happening behind the scenes, so we're not quite ready to bring in outside contributions just yet.

Once we reach an "official" V1, we’d love to have you onboard!
Looking forward to opening things up for contributions in the future. It's awesome to know there are people like you who are excited to jump in.

Thanks for your patience and understanding.

@BenniEngel BenniEngel self-assigned this Nov 5, 2024
@BenniEngel BenniEngel linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants