Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixpanel does not comply with PSR-4 #59

Open
zoe-edwards opened this issue Feb 16, 2021 · 3 comments
Open

Mixpanel does not comply with PSR-4 #59

zoe-edwards opened this issue Feb 16, 2021 · 3 comments
Assignees

Comments

@zoe-edwards
Copy link

Mixpanel should be in its own namespace in order to comply:

https://www.php-fig.org/psr/psr-4/

A fully qualified class name has the following form:

\<NamespaceName>(\<SubNamespaceNames>)*\<ClassName>

  • The fully qualified class name MUST have a top-level namespace name, also known as a “vendor namespace”.
  • The fully qualified class name MAY have one or more sub-namespace names.
  • The fully qualified class name MUST have a terminating class name.
  • Underscores have no special meaning in any portion of the fully qualified class name.
  • Alphabetic characters in the fully qualified class name MAY be any combination of lower case and upper case.
  • All class names MUST be referenced in a case-sensitive fashion.
@maxleroy
Copy link

maxleroy commented Mar 2, 2021

Yes, it would be highly appreciated if Mixpanel would update the packages to use "modern technologies" such as namespaces (php5.3 😬) and psr-4 autoloading, may be even provide a class to help testing (like a handler that can be inspected to use in functional tests..)

@Rockburner
Copy link

Seconded. Trying to implement mixpanel now and this is a definite impediment to an easy implementation.

@mauriblint
Copy link

Same problem here

@austinpray-mixpanel austinpray-mixpanel self-assigned this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants