Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to make the BPM display flash on the beat (i.e. at the rate of the BPM) when track is playing? #12128

Open
mxmilkiib opened this issue Oct 17, 2023 · 4 comments

Comments

@mxmilkiib
Copy link
Contributor

Feature Description

This would would give visual feedback as to whether the BPM analysed for a track is correct for the track (and if the beatgrid is on the down beat).

@ronso0
Copy link
Member

ronso0 commented Oct 17, 2023

There is already a control that does exactly that [ChannelN], beat_active.

So, while it's possible, what would be a good place to put this indicator?
I'm hesitant to add it to the BPM display because that already doubles as BPM tap button in (all?) official skins (which flashes on click), and adding another indicator might be too much.

@daschuer
Copy link
Member

We have as similar request here:
#5852

I can also remember to discuss a beat led on a controller using "beat_distance" but I cannot find it anymore.

@daschuer
Copy link
Member

Oh yes "beat_active" #3608

@ghost
Copy link

ghost commented Oct 17, 2023

There is already a control that does exactly that [ChannelN], beat_active.

So to be sure: it's just a beat LED that flashes on the beat? If you increase the pitch slider, it goes faster, if you decrease it goes slower. Or is it doing much more then that?
Beat LEDs were used on 90s mixers when there were no BPM counters on mixers (real hardware).
Is is this kind of behavior you are talking about?

So, while it's possible, what would be a good place to put this indicator? I'm hesitant to add it to the BPM display because that already doubles as BPM tap button in (all?) official skins (which flashes on click), and adding another indicator might be too much.

Yes, it would be too much!
Maybe there could be a choice, also using my request #12078

  • no BPM counter: for learning how to beatmatch
  1. beat LED enabled
  2. beat LED disabled

So this combination of BPM counter disabled and beat LED enabled, would be perfect for learning beatmatch!

  • BPM counter: choice to have beat LED too
  1. beat LED enabled
  2. beat LED disabled

I made a screenshot of where I think it could be nice (see red dot). Just on top of the BPM counter, since it's related.
But it should be able to disable separately from the BPM counter (not in the same BPM display)

afbeelding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants