Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation while using custom engine #281

Open
punqbund opened this issue Mar 11, 2019 · 1 comment
Open

Validation while using custom engine #281

punqbund opened this issue Mar 11, 2019 · 1 comment

Comments

@punqbund
Copy link

punqbund commented Mar 11, 2019

I am using MJML App 2.10.0 based on MJML v^4.1.2 on macOS. When I switch to a custom engine v.4.3.1 installed via npm (/Users/punqbund/node_modules/.bin/mjml), the code validation stops working.

Example: no error messages when trying to use mj-section inside of the other mj-section.

I would like to see the validation working with custom engines.

@kmcb777
Copy link
Contributor

kmcb777 commented Mar 11, 2019

Actually when using a custom engine the app will process the mjml using the cli output, so it could be possible but requires to exec the cli a second time with the --validate option and parsing the output.
Maybe we should add a separate option to activate this since it will make the renders slower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants