Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML App Gallery sphero-mini shows nesting error of miml component #368

Open
DanielOberlechner opened this issue Feb 1, 2022 · 2 comments

Comments

@DanielOberlechner
Copy link

Describe the bug
See title | not sure if this mjml problem or mjml-app problem, tried first here...

To Reproduce
Steps to reproduce the behavior:
I downloaded the miml app for macOS.
Went to the Gallery and searched for a pre-made template.
Found the template sphero-mini and opened it:
Got greeted by a linting error from the app that mj-spacer cannot be used inside mj-body.

Expected behavior
No error's should be shown on a pre-made template.

Screenshots
github

Environment (please complete the following information):

  • OS: macOS 12.3 Beta
  • App Version newest from Github
@DanielOberlechner
Copy link
Author

Have seen now bugs in other templates as well.
Attribute vertical-align is illegal
Attributes color, font-family are illegal ...
(in the happy new year theme email)

@iRyusa
Copy link
Member

iRyusa commented Nov 23, 2022

Well some templates comes from community so they're not really "linted" properly sometimes. It happens, at least the editor told you so :D
And for some, they come from older version of MJML (some where directly taken from Mailjet before MJML was a thing yet) so they're not sanitized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants