Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML Preview doesn't work if there is a HTML comment before the opening MJML tag in 2.0.0 #57

Open
jonosheehy opened this issue Nov 5, 2024 · 0 comments

Comments

@jonosheehy
Copy link

jonosheehy commented Nov 5, 2024

Many of my MJML files start with a HTML comment. But, as of extension version 2.0.0 having this comment before the opening tag is breaking the MJML Preview function. (Nothing appears in the preview pane.) As soon as I delete the comment from before the opening tag, the preview appears in the preview pane.

Code sample

Here is a code sample that will prevent the preview from displaying anything in 2.0.0:

<!-- Template information here -->
<mjml>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-image width="100px" src="https://mjml.io/assets/img/logo-small.png"></mj-image>
        <mj-divider border-color="#F45E43"></mj-divider>
        <mj-text font-size="20px" color="#F45E43" font-family="helvetica">Hello World</mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Specifications

  • VS Code version: 1.95.1
  • MJML extension version: 2.0.0
  • Operating system and version: Windows 11 Business
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant