Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --check Feature to Log Errors and Continue Checking #818

Open
DonRichards opened this issue Aug 22, 2024 · 1 comment
Open

Improve --check Feature to Log Errors and Continue Checking #818

DonRichards opened this issue Aug 22, 2024 · 1 comment

Comments

@DonRichards
Copy link
Contributor

Description:

The --check feature in Islandora Workbench performs a dry run of a migration by validating the CSV file, checking column correlations to Drupal fields, and identifying other potential issues. Currently, the tool exits upon encountering the first error, necessitating multiple runs to address each issue individually.

Proposed Enhancement:

Enhance the --check functionality to:

  1. Log errors encountered during the check into a detailed log file.
  2. Skip over erroneous lines or issues in the CSV and continue the validation process.
  3. Group obvious repeat issues (like a column is missing, or multiple characters in a column is expected to be EDTF date complaints, etc.)
  4. Provide a comprehensive summary of all detected issues at the end of the validation process.

Benefits:

  • Efficiency: Reduces the need for multiple runs of the --check feature, speeding up the migration preparation process.
  • Pattern Identification: Allows for the identification of recurring issues across the CSV, enabling more systematic corrections.
  • User Experience: Improves the overall user experience by providing a complete list of issues and allowing users to address all problems in one go.

Additional Information:

Consider including options for stop-one-first-error or continue-on-error and ensure that the error log is easily accessible for review. This enhancement will be particularly useful for users handling large and complex migrations.

@mjordan
Copy link
Owner

mjordan commented Aug 26, 2024

The perform_soft_checks config setting does this for some errors, but not all. No reason its scope can't be extended though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants