Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Server GUI crash when configured audio source is no longer present && attempting to start server #122

Closed
foxsouns opened this issue Dec 30, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@foxsouns
Copy link

Describe the bug
(Assuming the "Start server" when app starts is enabled): The app crashes immediately when the audio source it is configured to use is removed, and will crash on start if the configured audio source is not present. The "Start server" setting appears to bypass an existing check to prevent you from starting a server with a null source.

To Reproduce
Steps to reproduce the behavior:

  1. Launch app, configure audio endpoint directly (ex: set to "Headphones" in port 1, not "Default")
  2. Tick "Start Server" in settings
  3. Remove audio source while app is running/trying to start (ex: remove headphones from port 1)
  4. App crashes

Expected behavior
The app should handle a missing audio endpoint when you try to start a server. Do not assume bad input will never reach your running app. The app should consider what to do when given null input: consider using a back-up config file when parameters are not valid, like using the "Default" audio source.

Screenshots
Frame of application before crashing (with configured audio input not present)
image

Frame of working application (with said audio present)
image

Setting in app that causes crash
image

Server (please complete the following information):

  • OS: Windows 10, Version 10.0.19045 Build 19045
  • GUI or CMD: GUI
  • Version v0.3.0, tested and still broken on v0.3.1

Android (please complete the following information):

  • Device: Alcatel A564BL
  • OS: Android 7
  • Version v0.3.0

Additional information
I ran the app a few times under different conditions. The first few are with "Start server" on launch disabled, attempting to run with/without the configured headset disabled. The last 2 are with "Start server" on launch enabled.
server.log

@foxsouns foxsouns added the bug Something isn't working label Dec 30, 2024
@mkckr0
Copy link
Owner

mkckr0 commented Jan 2, 2025

fix at 93b56d3

@foxsouns
Copy link
Author

foxsouns commented Jan 2, 2025

waiting for a build to test on my machine, looks good in source, but i will close issue when i can verify it's fixed

@mkckr0
Copy link
Owner

mkckr0 commented Jan 3, 2025

AudioShareServer.zip

@foxsouns
Copy link
Author

foxsouns commented Jan 4, 2025

seems to fix it! closing

@foxsouns foxsouns closed this as completed Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants