Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include esy fallback for unsupported platforms #13

Open
jchavarri opened this issue May 17, 2020 · 1 comment
Open

Include esy fallback for unsupported platforms #13

jchavarri opened this issue May 17, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jchavarri
Copy link
Collaborator

@aantron added in bisect_ppx a really nice fallback approach where after downloading, the ppx will build with esy if the user platform is not supported by the prebuilt binaries.

Would be nice to add this to the hello-ppx-esy example.

@jchavarri jchavarri added good first issue Good for newcomers help wanted Extra attention is needed labels May 17, 2020
@aantron
Copy link

aantron commented May 17, 2020

Bisect_ppx is set up so that this fallback approach is actually the primary build system for release binaries. Since the binaries are missing in master, this triggers the "fallback" when master is installed in CI, and the CI caches the result of the binary build to create the binary release (branch binaries).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants