Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General HebbianModel refactoring #4

Open
Pibborn opened this issue Jul 24, 2018 · 1 comment
Open

General HebbianModel refactoring #4

Pibborn opened this issue Jul 24, 2018 · 1 comment

Comments

@Pibborn
Copy link
Collaborator

Pibborn commented Jul 24, 2018

I am not very happy about the current state of HebbianModel.py.

  1. Not enough separation between high-level code (referring to the hebbian model and its object attributes) and low-level code (involving class dictionaries and so on)
  2. the evaluate() function is a mess.
  3. there must be some other way to produce plots than the one that is currently in place.

These feel like three separate issues, but I probably need to rewrite the evaluation code in general. I feel it is kind of OK if we just want to be done with the current experiments, but I would not feel comfortable releasing it to the open.

@Pibborn
Copy link
Collaborator Author

Pibborn commented Jul 27, 2018

I am kind of happier now that commit 7b20b64 is in, but I am going to keep this open. I was a bit harsh on evaluate(.) and I don't really see a way to achieve 1., but 3. is definitely OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant