Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MORAE] Add support for when the LHS of an ODE can not be extracted #623

Open
Tracked by #632
Free-Quarks opened this issue Nov 7, 2023 · 1 comment
Open
Tracked by #632

Comments

@Free-Quarks
Copy link
Collaborator

We should add a case for when the LHS of an ODE cannot be extracted. We have 2 heuristics right now, but we should have it setup so incase they fail we fill in the LHS with placeholder names. I recommend state1, state2, etc...

We do need each LHS placeholder name to be different for the specific set of equations (hence the indexing in my recommendation), primarily for our support of partial extraction with this.

There is slight chance the acset portion of the pipeline might give extra bad results, as in a blank AMR's for the placeholder names. If so I'll fix that, but mentioning that here to track that issue if it arises.

@myedibleenso
Copy link
Collaborator

Relates to #629 and #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants