From 042d943e3904b88b9e60d46ed00b44c5ada08e59 Mon Sep 17 00:00:00 2001 From: Matthias Richter Date: Tue, 23 Jan 2024 13:51:38 +0100 Subject: [PATCH] Update ECR image name --- images/Dockerfile | 1 - scripts/build_base_image.sh | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/images/Dockerfile b/images/Dockerfile index b3bffcee..4bafaa79 100644 --- a/images/Dockerfile +++ b/images/Dockerfile @@ -7,7 +7,6 @@ RUN apt-get update && \ apt-get install git -y # Install Fondant -# This is split from other requirements to leverage caching ARG FONDANT_VERSION=main RUN pip3 install fondant[component,aws,azure,gcp]@git+https://github.com/ml6team/fondant@${FONDANT_VERSION} diff --git a/scripts/build_base_image.sh b/scripts/build_base_image.sh index f832e9aa..1c41b95c 100755 --- a/scripts/build_base_image.sh +++ b/scripts/build_base_image.sh @@ -39,8 +39,8 @@ for python_version in "${python_versions[@]}"; do # Build docker images and push to docker hub docker build --push "${args[@]}" \ - --build-arg PYTHON_VERSION=$python_version \ - --build-arg FONDANT_VERSION=$tag \ + --build-arg="PYTHON_VERSION=${python_version}" \ + --build-arg="FONDANT_VERSION=${tag}" \ -f "images/Dockerfile" \ . done