Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fondant dev image if fondant dev version is installed #820

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Jan 30, 2024

When fondant is installed locally (fondant_version=0.1.dev0) the base image tag is set to dev automatically.
The previous PR (#818) was merged to fast without this change.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr!

scripts/build_base_image.sh Outdated Show resolved Hide resolved
tests/pipeline/test_python_component.py Show resolved Hide resolved
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr!

scripts/build_base_image.sh Outdated Show resolved Hide resolved
@mrchtr mrchtr merged commit 115fe9f into main Jan 30, 2024
11 checks passed
@mrchtr mrchtr deleted the fix/fondant-base-dev-image branch January 30, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants