Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define and set a unique user-agent #761

Open
goeffthomas opened this issue Nov 1, 2024 · 1 comment
Open

Define and set a unique user-agent #761

goeffthomas opened this issue Nov 1, 2024 · 1 comment

Comments

@goeffthomas
Copy link
Contributor

If the metadata for Croissant is pulled via URL (done here), we should set a user-agent that allows the package to be identified.

For reference, kagglehub does something similar here
@goeffthomas goeffthomas changed the title Define and set a unique user-agent for Define and set a unique user-agent Nov 1, 2024
@goeffthomas
Copy link
Contributor Author

We should probably add that same user agent when downloading the files over HTTP: https://github.com/mlcommons/croissant/blob/main/python/mlcroissant/mlcroissant/_src/operation_graph/operations/download.py#L188-L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
mlcroissant
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goeffthomas