Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong conv, no spare, no likehood train #3

Open
ddz16 opened this issue Apr 9, 2021 · 2 comments
Open

wrong conv, no spare, no likehood train #3

ddz16 opened this issue Apr 9, 2021 · 2 comments

Comments

@ddz16
Copy link

ddz16 commented Apr 9, 2021

Thanks for your code. But I think your code is very different from the method which the paper mentioned.

@ChenS676
Copy link

I just found in the implementation the output is used in combination with input, where is obviously not the real case in practise. If you just use input performance decays about 10%.

@WLW2980
Copy link

WLW2980 commented Jul 26, 2023

yes , I agree with @ChenS676. The validate part is wrong, beacuse the truth target is also input and it will cause 'cheating' since In fact we do not know the true value(target here) when using model to predict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants