Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end_time in task dataframes is not counted as an event (right open interval) #110

Open
juancq opened this issue May 28, 2024 · 1 comment

Comments

@juancq
Copy link
Contributor

juancq commented May 28, 2024

The end_time in a task dataframe is not counted as an event. I am not sure if this is a bug or if it's by design (if it's the latter, just a documentation update would do).

For example, in a task dataframe as listed below, for subject 1520408 let's assume two events before 2010-10-20 and one event on 2010-10-20, recording end_time as 2010-10-20 would be treated as a sequence of two events during the call to filter_to_min_seq_len in

def filter_to_min_seq_len(self):
.

subject_id end_time label start_time
u32 datetime[μs] u32 datetime[μs]
1520408 2010-10-20 00:00:00 1 null
1569956 2010-02-14 00:00:00 1 null
1230099 2010-06-27 00:00:00 2 null

If the endtime is not meant to be included (as it currently is), it would be helpful to have a note in the documentation stating this.

@juancq juancq changed the title end_time in task dataframes is not counted as an event end_time in task dataframes is not counted as an event (right open interval) May 28, 2024
@mmcdermott
Copy link
Owner

@juancq I'm not sure, but is it possible the change here: #107 solves this issue? Or am I misunderstanding the scope of the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants