Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATEGORICAL_ONLY v. NUMERICAL_ONLY v. CATEGORICAL_AND_NUMERICAL is confusing. #13

Open
mmcdermott opened this issue May 9, 2023 · 0 comments
Labels
refactor Clean up code, testing interface, or API.

Comments

@mmcdermott
Copy link
Owner

This has two disparate impacts.

First, in embedding, if embeddings are split by categorical and numerical, then this really means you only embed the indicated things. If the embeddings aren't split, then NUMERICAL_ONLY and CATEGORICAL_AND_NUMERICAL are equivalent at the input layer, as there is no way to not embed the categorical data alongside the numerical. In the joint case, CATEGORICAL ONLY gives all values a value of 1, which is odd.

Then, at generation time, it indicates what is generated / predicted in each given layer of the dep graph.

@mmcdermott mmcdermott added the refactor Clean up code, testing interface, or API. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Clean up code, testing interface, or API.
Projects
None yet
Development

No branches or pull requests

1 participant