Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the enable_collection exposed by the binding #92

Open
caizixian opened this issue Nov 1, 2021 · 1 comment
Open

Rename the enable_collection exposed by the binding #92

caizixian opened this issue Nov 1, 2021 · 1 comment

Comments

@caizixian
Copy link
Member

#88 calls the correct method after changed in mmtk/mmtk-core#474. However, we should rename the enable_collection function (and create a new JikesRVM syscall) as well to avoid confusion.

@qinsoon
Copy link
Member

qinsoon commented Nov 1, 2021

I suggest we keep the name enableCollection/enable_collection() in JikesRVM and inevitably in the binding as well. It is used in JikesRVM in the following code:

    if (VM.BuildWithRustMMTk) {
      sysCall.sysEnableCollection(Magic
              .objectAsAddress(RVMThread.getCurrentThread()));
    } else {
      Selected.Plan.get().enableCollection();
    }

I think we want to keep the third party call consistent with the Java MMTk call. So think about it in this way: JikesRVM requires the heap implementation to provide a way to enable collection (for third party heap and for Java MMTk), and in the binding, we implement the enable collection call for JikesRVM, and we call initialize_collection() in mmtk core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants