Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3 #8

Open
mmurray opened this issue Jan 30, 2021 · 5 comments
Open

Upgrade to Python 3 #8

mmurray opened this issue Jan 30, 2021 · 5 comments

Comments

@mmurray
Copy link
Owner

mmurray commented Jan 30, 2021

The upstream Matterport3DSim codebase has moved on to Python 3 (and updated some other dependencies). We should pull those changes down, but it will require combing through the CVDN/NDH python files and updating old Python 2 syntax.

@ManaalAhi
Copy link

Hello,
Thank you for your speedy response. However, I am getting many more errors with regards to setting up using the docker file. I have attached screen shots below:

Screenshot 2021-02-01 at 13 54 05

Screenshot 2021-02-01 at 13 54 38

When running the file requirements.txt file from within the docker container the following error occurs:
Screenshot 2021-02-01 at 13 54 51

As a result, I believe that that execution of the train.py, leads to the following:
Screenshot 2021-02-01 at 13 58 49cvdn

I am not certain, as to which dependancies are necessary for the code, and would be grateful if you could look into this.

@mmurray
Copy link
Owner Author

mmurray commented Feb 1, 2021

Sorry about that. I had merged an automated pull request to upgrade Pillow without testing it. I reverted that change so installing from the requirements.txt should work again now.

@g-jing
Copy link

g-jing commented Nov 10, 2021

Hi! I have several questions.

  1. I was reproducing the seq-to-seq model but your provided model is using python2. Do you have the baseline where you use python3?
  2. After I installed and enter the container as in the instruction, does the environment support python3 code? Or the environment only fit python2?

Thanks!

@LemonZhong
Copy link

Same problems. Please solve it, please!
1.I was reproducing the seq-to-seq model but your provided model is using python2. Do you have the baseline where you use python3?
2.After I installed and enter the container as in the instruction, does the environment support python3 code? Or the environment only fit python2?

Can you please use Python 3?

@mmurray
Copy link
Owner Author

mmurray commented Sep 30, 2023

When this codebase was created it was based off of the Matterport3DSimulator repository which at the time only supported Python 2. I would welcome any PRs that moved the codebase to Python 3 but I don't have imminent cycles to work on it and I'm not sure when I will be able to prioritize it.

To get an idea of what is involved, you can see Matterport3DSim's commit when they moved to python3: peteanderson80/Matterport3DSimulator@cb196b6#diff-8a2bb86ab24f4c016dba899aba3904d347e9c19c96f825d5a5d871fab6a64bf3

I think we would need to make similar changes for the files in tasks/NDH: https://github.com/mmurray/cvdn/tree/master/tasks/NDH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants