MAINT: Add and check type hints #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Green @hoechenberger ! |
drammock
reviewed
Sep 13, 2024
Co-authored-by: Daniel McCloy <[email protected]>
|
@hoechenberger let me know if you want to look otherwise I'll go ahead and merge! |
|
Hey, I won't have time to review until Friday or Saturday will that suffice? |
|
Sure! |
|
@hoechenberger okay for me to fix the merge conflict and merge? |
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#1006) [pre-commit.ci] pre-commit autoupdate (mne-tools#1002) allow missing sessions (mne-tools#1000) [pre-commit.ci] pre-commit autoupdate (mne-tools#1001)
hoechenberger
approved these changes
Oct 26, 2024
|
Excellent work, @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial push to see if I broke anything.
docs/source/changes.md)Closes #994