Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Type checking #994

Closed
larsoner opened this issue Sep 11, 2024 · 1 comment · Fixed by #995
Closed

ENH: Type checking #994

larsoner opened this issue Sep 11, 2024 · 1 comment · Fixed by #995

Comments

@larsoner
Copy link
Member

@hoechenberger I saw in a recent PR that @drammock added some missing type hints. I am not very experienced with type checking but this repo seems pretty well documented -- worth adding mypy to pre-commit or at least a CI run? I briefly tried both mypy and pyright and mypy was a little bit faster and used already by MNE so I'm inclined to try that.

I already see some annoyingness with TypedDict not subclassing dict but I'll look into that if type checking does seem worthwhile.

@agramfort
Copy link
Member

agramfort commented Sep 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants