You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@hoechenberger I saw in a recent PR that @drammock added some missing type hints. I am not very experienced with type checking but this repo seems pretty well documented -- worth adding mypy to pre-commit or at least a CI run? I briefly tried both mypy and pyright and mypy was a little bit faster and used already by MNE so I'm inclined to try that.
I already see some annoyingness with TypedDict not subclassing dict but I'll look into that if type checking does seem worthwhile.
The text was updated successfully, but these errors were encountered:
@hoechenberger I saw in a recent PR that @drammock added some missing type hints. I am not very experienced with type checking but this repo seems pretty well documented -- worth adding
mypy
to pre-commit or at least a CI run? I briefly tried bothmypy
andpyright
andmypy
was a little bit faster and used already by MNE so I'm inclined to try that.I already see some annoyingness with TypedDict not subclassing dict but I'll look into that if type checking does seem worthwhile.
The text was updated successfully, but these errors were encountered: