From a900d8e5b83005efa32f490cf088f893f0fe021b Mon Sep 17 00:00:00 2001 From: Nicolas Busato Date: Thu, 12 Oct 2023 20:36:50 -0300 Subject: [PATCH] fix: change ci param to errorbar in sns-catplot (#524) Co-authored-by: Eric Larson --- doc/changelog.rst | 2 ++ examples/general/plot_12_group_glm.py | 4 ++-- examples/general/plot_16_waveform_group.py | 2 +- mne_nirs/tests/test_examples.py | 1 - 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/changelog.rst b/doc/changelog.rst index 4977cfc02..33c4667e6 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -17,6 +17,7 @@ To install a specific version of the library you would run ``pip install mne-nir v0.6.dev0 --------- +* Changed ci param to errorbar in sns-catplot functions. By `Nicolas Busato`_. * Fix bug in SNIRF writer that caused incorrect duration to be written to file. By `Robert Luke`_. * Add option to export montage location in SNIRF using the landmarkLabels field. By `Robert Luke`_. * Fix continuous integration issues and update test infrastructure. By `Florin Pop`_. @@ -197,3 +198,4 @@ Enhancements .. _Samuel Powell: https://github.com/samuelpowell .. _Johann Benerradi: https://github.com/HanBnrd .. _Florin Pop: https://github.com/florin-pop +.. _Nicolas Busato: https://github.com/Busato diff --git a/examples/general/plot_12_group_glm.py b/examples/general/plot_12_group_glm.py index e03efb275..c31cc8189 100644 --- a/examples/general/plot_12_group_glm.py +++ b/examples/general/plot_12_group_glm.py @@ -278,7 +278,7 @@ def individual_analysis(bids_path, ID): grp_results = df_roi.query("Condition in ['Control', 'Tapping_Left', 'Tapping_Right']") grp_results = grp_results.query("Chroma in ['hbo']") -sns.catplot(x="Condition", y="theta", col="ID", hue="ROI", data=grp_results, col_wrap=5, ci=None, palette="muted", height=4, s=10) +sns.catplot(x="Condition", y="theta", col="ID", hue="ROI", data=grp_results, col_wrap=5, errorbar=None, palette="muted", height=4, s=10) # %% @@ -372,7 +372,7 @@ def individual_analysis(bids_path, ID): df = statsmodels_to_results(roi_model) -sns.catplot(x="Condition", y="Coef.", hue="ROI", data=df.query("Chroma == 'hbo'"), ci=None, palette="muted", height=4, s=10) +sns.catplot(x="Condition", y="Coef.", hue="ROI", data=df.query("Chroma == 'hbo'"), errorbar=None, palette="muted", height=4, s=10) # %% diff --git a/examples/general/plot_16_waveform_group.py b/examples/general/plot_16_waveform_group.py index 742933dda..96e761cad 100644 --- a/examples/general/plot_16_waveform_group.py +++ b/examples/general/plot_16_waveform_group.py @@ -349,7 +349,7 @@ def individual_analysis(bids_path): # For this reason, fNIRS is most appropriate for detecting changes within a # single ROI between conditions. -sns.catplot(x="Condition", y="Value", hue="ID", data=df.query("Chroma == 'hbo'"), ci=None, palette="muted", height=4, s=10) +sns.catplot(x="Condition", y="Value", hue="ID", data=df.query("Chroma == 'hbo'"), errorbar=None, palette="muted", height=4, s=10) # %% diff --git a/mne_nirs/tests/test_examples.py b/mne_nirs/tests/test_examples.py index 5fecfcea3..e7fe15ded 100644 --- a/mne_nirs/tests/test_examples.py +++ b/mne_nirs/tests/test_examples.py @@ -46,7 +46,6 @@ def examples_path(): @pytest.mark.filterwarnings('ignore:No bad channels to interpolate.*:') @pytest.mark.filterwarnings('ignore:divide by zero encountered.*:') @pytest.mark.filterwarnings('ignore:invalid value encountered.*:') -@pytest.mark.filterwarnings("ignore:.*\n\nThe `ci` parameter is deprecated.*:") @pytest.mark.skipif( sys.platform.startswith('win'), reason='Unstable on Windows') @pytest.mark.examples