Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on example code #11

Open
Berkmann18 opened this issue Feb 21, 2019 · 4 comments
Open

Error on example code #11

Berkmann18 opened this issue Feb 21, 2019 · 4 comments

Comments

@Berkmann18
Copy link
Contributor

Berkmann18 commented Feb 21, 2019

When I run

name-your-contributors -u mntnr -r name-your-contributors -t $GITHUB_TOKEN > nyc.json
cat nyc.json | whodidwhat

I get this (same output as name-your-... | whodidwhat):

TypeError: Cannot read property 'map' of undefined
  at cat (/usr/lib/node_modules/whodidwhat/src/index.js:20:20)
  at loopField (/usr/lib/node_modules/whodidwhat/src/index.js:23:30)
  at typeMap.map (/usr/lib/node_modules/whodidwhat/src/index.js:46:27)
  at Array.map (<anonymous>)
  at byUser (/usr/lib/node_modules/whodidwhat/src/index.js:46:11)
  at process._tickCallback (internal/process/next_tick.js:68:7)

I had a quick look at the code but couldn't really understand why that was happening.

To reproduce this, do the following:

npm i -g name-your-contributors whodidwhat
export GITHUB_TOKEN=yourTokenHere
name-your-contributors -u mntnr -r name-your-contributors -t $GITHUB_TOKEN > nyc.json
cat nyc.json | whodidwhat

EDIT: This doesn't happen when using cli.js on a repo clone.

@RichardLitt
Copy link
Member

I had the same issue.

@Berkmann18
Copy link
Contributor Author

Do you know what could cause that?

@RichardLitt
Copy link
Member

It may have already been solved, if it doesn't happen in the src folder. Thomas is AFK for a few days, but said he'd hand over publishing rights so I can test that next week. Hold tight!

@Berkmann18
Copy link
Contributor Author

Okay :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants