Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "RealTransform" transformations #30

Open
constantinpape opened this issue Mar 29, 2021 · 3 comments
Open

Support "RealTransform" transformations #30

constantinpape opened this issue Mar 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@constantinpape
Copy link
Contributor

https://github.com/BIOP/qupath-biop-extensions/tree/imglib2-include/src/main/java/ch/epfl/biop/qupath/transform

@constantinpape
Copy link
Contributor Author

cc @martinschorb @NicoKiaru @tischi

@tischi
Copy link
Contributor

tischi commented Mar 29, 2021

@NicoKiaru

Do you know if the convention is to put the "type" only in case of the field being an interface?
Would make sense to me, because if it is not an interface, on the Java code side, it is clear from the class of the field what it should be.

However, from human readability point of view it could be nice to spell out the type also if it is not an interface, but then I think one looses quite some of the convenience of the JSON magic.

@NicoKiaru
Copy link

Do you know if the convention is to put the "type" only in case of the field being an interface?

I think so, in fact in most cases you don't need to write adapters, because the object can be easily serialized. It's not really a convention, it's because there's no other convenient.

However, from human readability point of view it could be nice to spell out the type also if it is not an interface, but then I think one looses quite some of the convenience of the JSON magic.

Gson is powerful and configurable, it is probably possible to set it in such a way that the type of the object is always written (but what happens if you serialize an int?)

@constantinpape constantinpape added the enhancement New feature or request label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants