Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Ability to select the installation destination folder? #59

Open
g40 opened this issue Apr 3, 2024 · 6 comments
Open

Windows: Ability to select the installation destination folder? #59

g40 opened this issue Apr 3, 2024 · 6 comments

Comments

@g40
Copy link

g40 commented Apr 3, 2024

Sort of critical here as Windows is booted from a (small) virtual disk which does not have large amounts of free space on drive c:

I can probably submit a PR if the installer is comprehensible.

BTW looks like very nice work. Thanks.

@dscb57
Copy link

dscb57 commented Nov 6, 2024

I also think that this is an important issue. At the same time there needs to be a secondary installation section (as found on most installers) to allow selection of drive/folder for other larger content requiring more disk space, so as not to compromise the typically small size of the C:/ drive on a Windows PC, as well as avoiding the need to use symbolic links.

@falkTX
Copy link
Member

falkTX commented Nov 6, 2024

its not just a matter of adding a custom install folder, it needs to store that location in the registry too so that the plugin version can know where to find the main files.
then also needing some code to read that registry entry when running in plugin mode (which needs native code, the plugin cannot use Qt like the standalone can)

@g40
Copy link
Author

g40 commented Nov 6, 2024

@falkTX I don't get it. Why would it need a registry entry and related code if installed elsewhere? From your comment it is not needed for an install to Program Files? I can understand it being added to the Windows path but that would apply to both scenarios?
Thanks for listening.

@falkTX
Copy link
Member

falkTX commented Nov 6, 2024

it is needed in order to find the custom install location.

if the location is fixed then we dont need it anymore since we can assume where it got installed in

@g40
Copy link
Author

g40 commented Nov 6, 2024

@falkTX That's not very robust. Where in the codebase is the installation folder hard-coded?

@falkTX
Copy link
Member

falkTX commented Nov 6, 2024

for windows its in the installer, that being https://github.com/mod-audio/mod-desktop/blob/main/utils/win64/win64-installer.iss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants